leesf commented on a change in pull request #1460: [HUDI-679] Make io package
Spark free
URL: https://github.com/apache/incubator-hudi/pull/1460#discussion_r399673870
##########
File path:
hudi-client/src/main/java/org/apache/hudi/execution/CopyOnWriteLazyInsertIterable.java
##########
@@ -50,15 +51,23 @@
protected final HoodieTable<T> hoodieTable;
protected final String idPrefix;
protected int numFilesWritten;
+ protected Supplier<Integer> idSupplier;
+ protected Supplier<Integer> stageSupplier;
+ protected Supplier<Long> attemptSupplier;
public CopyOnWriteLazyInsertIterable(Iterator<HoodieRecord<T>>
sortedRecordItr, HoodieWriteConfig config,
- String instantTime, HoodieTable<T>
hoodieTable, String idPrefix) {
+ String instantTime, HoodieTable<T>
hoodieTable, String idPrefix,
+ Supplier<Integer> idSupplier,
Supplier<Integer> stageSupplier,
+ Supplier<Long> attemptSupplier) {
Review comment:
> Actually, I am not sure if we can package these three args into a DTO
structure. Just a thought, you can ignore.
Yes, I think it is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
