fengjian428 commented on PR #6122: URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186816730
> > I also found this, but there is a LOCK_ACQUIRE_WAIT_TIMEOUT_MS when using zk or hive lock provider, so I feel this may not be a big problem. > > The config items: LOCK_ACQUIRE_WAIT_TIMEOUT_MS and LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS are different. The front one is to define the timeout of acquisition and the second is for the retry interval. If we do not have an interval between retry, then the while loop will finish faster. > > > I have another idea, can we let every lock provider return false if it cannot acquire a lock? WDYT > > Why? what's the purpose? What I mean is, For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? if want to return false or return HoodieLockException or return InterruptedException, you need some motivation, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
