yanghua commented on PR #6122: URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186848754
oops... I misunderstood your thought. I thought you want only return bool values for method `tryLock`. > What I mean is, For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first if want to return false or return HoodieLockException or return InterruptedException, should mean something eg: if lockprovider returns a IllegalArgumentException we don't need to retry since it will always illegal reasonable. IMHO, we can start a new thread to discuss this topic and if we need to refactor. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
