alexeykudinkin commented on code in PR #5523:
URL: https://github.com/apache/hudi/pull/5523#discussion_r927206437
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java:
##########
@@ -50,22 +51,27 @@ public class HoodieInternalRow extends InternalRow {
/**
* Collection of meta-fields as defined by {@link
HoodieRecord#HOODIE_META_COLUMNS}
+ *
+ * NOTE: {@code HoodieInternalRow} *always* overlays its own meta-fields
even in case
+ * when source row also contains them, to make sure these fields are
mutable and
+ * can be updated (for ex, {@link UnsafeRow} doesn't support mutations
due to
+ * its memory layout, as it persists field offsets)
*/
private final UTF8String[] metaFields;
- private final InternalRow row;
+ private final InternalRow sourceRow;
/**
- * Specifies whether source {@link #row} contains meta-fields
+ * Specifies whether source {@link #sourceRow} contains meta-fields
*/
- private final boolean containsMetaFields;
+ private final boolean sourceContainsMetaFields;
Review Comment:
Agreed, renamed to resolve confusion that arose in our previous discussion
regarding the scope of these fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
