trushev commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r927287333
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseMergeHelper.java:
##########
@@ -130,4 +145,48 @@ protected Void getResult() {
return null;
}
}
+
+ protected Iterator<GenericRecord> getRecordIterator(
+ HoodieTable<T, ?, ?, ?> table,
+ HoodieMergeHandle<T, ?, ?, ?> mergeHandle,
+ HoodieBaseFile baseFile,
+ HoodieFileReader<GenericRecord> reader,
+ Schema readSchema) throws IOException {
+ Option<InternalSchema> querySchemaOpt =
SerDeHelper.fromJson(table.getConfig().getInternalSchema());
+ if (!querySchemaOpt.isPresent()) {
+ querySchemaOpt = new
TableSchemaResolver(table.getMetaClient()).getTableInternalSchemaFromCommitMetadata();
+ }
+ boolean needToReWriteRecord = false;
+ Map<String, String> renameCols = new HashMap<>();
+ // TODO support bootstrap
+ if (querySchemaOpt.isPresent() &&
!baseFile.getBootstrapBaseFile().isPresent()) {
Review Comment:
I just moved this code snippet from `HoodieMergeHelper` to `BaseMergeHelper`
as is. Anyway I will think about avoiding unnecessary checks you pointed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
