trushev commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r927309714
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1667,16 +1667,14 @@ public void reOrderColPosition(String colName, String
referColName, TableChange.
private Pair<InternalSchema, HoodieTableMetaClient>
getInternalSchemaAndMetaClient() {
HoodieTableMetaClient metaClient = createMetaClient(true);
TableSchemaResolver schemaUtil = new TableSchemaResolver(metaClient);
- Option<InternalSchema> internalSchemaOption =
schemaUtil.getTableInternalSchemaFromCommitMetadata();
- if (!internalSchemaOption.isPresent()) {
- throw new HoodieException(String.format("cannot find schema for current
table: %s", config.getBasePath()));
- }
- return Pair.of(internalSchemaOption.get(), metaClient);
Review Comment:
Ok, thanks for the review. I will think about decoupling schema evo from the
other code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
