danny0405 commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r927367996
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieUnMergedLogRecordScanner.java:
##########
@@ -135,10 +137,15 @@ public Builder
withLogRecordScannerCallback(LogRecordScannerCallback callback) {
return this;
}
+ public Builder withInternalSchema(InternalSchema internalSchema) {
+ this.internalSchema = internalSchema;
+ return this;
Review Comment:
Yes, a very confusing practice, the reader/format should be deterministic to
one static given schema, it should not care about how the schema is generated,
or where it comes from, say: it should not be imposed to the evolution logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
