YannByron commented on code in PR #5746:
URL: https://github.com/apache/hudi/pull/5746#discussion_r928087048
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadata.java:
##########
@@ -170,7 +170,8 @@ Map<Pair<String, String>, HoodieMetadataColumnStats>
getColumnStats(final List<P
* @return {@link HoodieData} of {@link HoodieRecord}s with records matching
the passed in key prefixes.
*/
HoodieData<HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeyPrefixes(List<String> keyPrefixes,
-
String partitionName);
+
String partitionName,
+
boolean shouldLoadInMemory);
Review Comment:
can we declare a member variable named `shouldLoadColumnStatsInMemory` in
`FileSystemBackedTableMetadata`, so that we don't need to change the definition
of `getRecordsByKeyPrefixes`.
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadata.java:
##########
@@ -170,7 +170,8 @@ Map<Pair<String, String>, HoodieMetadataColumnStats>
getColumnStats(final List<P
* @return {@link HoodieData} of {@link HoodieRecord}s with records matching
the passed in key prefixes.
*/
HoodieData<HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeyPrefixes(List<String> keyPrefixes,
-
String partitionName);
+
String partitionName,
+
boolean shouldLoadInMemory);
Review Comment:
can we declare a member variable named `shouldLoadColumnStatsInMemory` only
in `FileSystemBackedTableMetadata`, so that we don't need to change the
definition of `getRecordsByKeyPrefixes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
