YannByron commented on code in PR #5746:
URL: https://github.com/apache/hudi/pull/5746#discussion_r928087048
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadata.java:
##########
@@ -170,7 +170,8 @@ Map<Pair<String, String>, HoodieMetadataColumnStats>
getColumnStats(final List<P
* @return {@link HoodieData} of {@link HoodieRecord}s with records matching
the passed in key prefixes.
*/
HoodieData<HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeyPrefixes(List<String> keyPrefixes,
-
String partitionName);
+
String partitionName,
+
boolean shouldLoadInMemory);
Review Comment:
Whether or not column statistics should be loaded in memory is the behavior
of a metadata table.
IMO, we can abstract a method named `shouldLoadColumnStatsInMemory` in
`HoodieTableMetadata`, the sub-classes can implement this, and use this in
their own `getRecordsByKeyPrefixes` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
