vinothchandar commented on a change in pull request #1453: HUDI-644 kafka connect checkpoint provider URL: https://github.com/apache/incubator-hudi/pull/1453#discussion_r400384846
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/checkpoint/KafkaConnectHdfsProvider.java ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.checkpoint; + +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.PathFilter; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Generate checkpoint from Kafka-Connect-HDFS. + */ +public class KafkaConnectHdfsProvider implements CheckPointProvider { Review comment: I think we can integrate this using a new `--initial-checkpoint-provider` flag that takes the name of the class that provides an initial checkpoint, if no commits/checkpoints are found on the hudi dataset itself.. The current behavior is probably to pass an Optional.empty to the Source class and let the sources decide (for e,g kafka will start from earliest/latest depending on what the user wants it to be)? We can encapsulate this behavior in a another InitialCheckpointProvider implementation, which will be the default value for `--initial-checkpoint-provider` flag ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
