garyli1019 commented on a change in pull request #1453: HUDI-644 kafka connect checkpoint provider URL: https://github.com/apache/incubator-hudi/pull/1453#discussion_r400409352
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/checkpoint/KafkaConnectHdfsProvider.java ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.checkpoint; + +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.PathFilter; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Generate checkpoint from Kafka-Connect-HDFS. + */ +public class KafkaConnectHdfsProvider implements CheckPointProvider { Review comment: Do we wanna integrate this with the delta streamer? My idea was to use this tool when not using delta streamer and save a checkpoint into the commit. Then the user can switch to delta streamer in the next run. If we integrate this with delta streamer, let's say the users are using kafka connect, they need to use Spark Datasource reader to do the initial bulk insert first, then the second run will be using delta streamer. But if we do the checkpoint scan in the second run, the checkpoint will not represent the data in the Hudi dataset, which means we need to do the checkpoint scan in the first run. It that makes sense? Or I am missing something ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
