5herhom commented on code in PR #6254:
URL: https://github.com/apache/hudi/pull/6254#discussion_r939539431
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieCopyOnWriteTableInputFormat.java:
##########
@@ -254,6 +260,8 @@ private List<FileStatus> listStatusForSnapshotMode(JobConf
job,
.stream()
.flatMap(Collection::stream)
.map(fileSlice -> createFileStatusUnchecked(fileSlice,
fileIndex, virtualKeyInfoOpt))
+ .filter(FileStatusOpt -> FileStatusOpt.isPresent())
Review Comment:
> > > Instead of changing the API of the `createFileStatusUnchecked`, let's
just move up this filtering to be preceding its invocation
> >
> >
> > I'v updated the commit. Please review again. Thx for advice.
>
> There is some wrong with the new code. I will fix it later.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
