5herhom commented on code in PR #6254:
URL: https://github.com/apache/hudi/pull/6254#discussion_r939608197
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieCopyOnWriteTableInputFormat.java:
##########
@@ -261,6 +263,20 @@ private List<FileStatus> listStatusForSnapshotMode(JobConf
job,
return targetFiles;
}
+ protected boolean checkIfValidFileSlice(FileSlice fileSlice) {
+ Option<HoodieBaseFile> baseFileOpt = fileSlice.getBaseFile();
Review Comment:
> checkIfValidFileSlice -> filterValidFileSlice ?
I'm not sure that if a boolean returned method return may throw an
IllegalXXXXException, it may be more appropriate to be named with checkXXXX. Is
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
