wuwenchi commented on code in PR #6320:
URL: https://github.com/apache/hudi/pull/6320#discussion_r939864950
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -875,6 +883,33 @@ public static <T> boolean
isDefaultValueDefined(Configuration conf, ConfigOption
|| conf.get(option).equals(option.defaultValue());
}
+ public static String getKeyGenClassNameByType(Configuration conf) {
+ String genType = conf.get(FlinkOptions.KEYGEN_TYPE);
Review Comment:
If you set the `KEYGEN_CLASS_NAME` default value, it does solve the problem
of not showing.
However, in the original logic, if `KEYGEN_CLASS_NAME` is not set,
`KEYGEN_TYPE` will be read.
Therefore, if the default value is set for `KEYGEN_CLASS_NAME`, the
`KEYGEN_TYPE` configuration is equivalent to completely useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
