wuwenchi commented on code in PR #6320:
URL: https://github.com/apache/hudi/pull/6320#discussion_r940866883
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -875,6 +883,33 @@ public static <T> boolean
isDefaultValueDefined(Configuration conf, ConfigOption
|| conf.get(option).equals(option.defaultValue());
}
+ public static String getKeyGenClassNameByType(Configuration conf) {
+ String genType = conf.get(FlinkOptions.KEYGEN_TYPE);
Review Comment:
If there is no current process, then `KEYGEN_CLASS_NAME` will not be
assigned, and there will be no KEYGEN_CLASS_NAME property in table properties.
If you set the default value of `KEYGEN_CLASS_NAME` as you said above, then
the `KEYGEN_TYPE` parameter will be invalid.
Therefore, I initialized `KEYGEN_CLASS_NAME` according to `KEYGEN_TYPE`, so
that not only can the value of `KEYGEN_CLASS_NAME` be saved in table
properties, but `KEYGEN_TYPE` can also take effect normally according to the
original logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
