the-other-tim-brown commented on code in PR #6170:
URL: https://github.com/apache/hudi/pull/6170#discussion_r940862177


##########
hudi-examples/hudi-examples-spark/pom.xml:
##########
@@ -230,6 +230,27 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <!-- Logging dependencies -->
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>

Review Comment:
   This log4j-1.2-api jar specifically contains implementations of the log4j 
api's that make it compatible with log4j2. I don't expect Spark to provide 
these for us. 
   
   The other dependencies below are either logging APIs which we should declare 
if we directly rely on them and other bridges that were required to make the 
examples log properly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to