umehrot2 commented on a change in pull request #1459: [HUDI-418] [HUDI-421]
Bootstrap Index using HFile and File System View Changes with unit-test
URL: https://github.com/apache/incubator-hudi/pull/1459#discussion_r403394224
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -207,6 +213,20 @@ public String getMetaAuxiliaryPath() {
return basePath + File.separator + AUXILIARYFOLDER_NAME;
}
+ /**
+ * @return Bootstrap Index By Partition Folder
+ */
+ public String getBootstrapIndexByPartitionFolderName() {
+ return getMetaAuxiliaryPath() + File.separator +
BOOTSTRAP_INDEX_BY_PARTITION_FOLDER_NAME;
+ }
+
+ /**
+ * @return Bootstrap Index By Hudi File Id Folder
+ */
+ public String getBootstrapIndexByFileIdFolderNameFolderName() {
+ return getMetaAuxiliaryPath() + File.separator +
BOOTSTRAP_INDEX_BY_FILE_ID_FOLDER_NAME;
+ }
Review comment:
`BOOTSTRAP_INDEX_BY_PARTITION_FOLDER_NAME` and
`BOOTSTRAP_INDEX_BY_FILE_ID_FOLDER_NAME` both already contain
`AUXILIARYFOLDER_NAME` in it. Here we are again prefixing the auxiliary path
while returning. I think this would be prefixing the path twice with aux
folder. Seems like a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
