umehrot2 commented on a change in pull request #1459: [HUDI-418] [HUDI-421]
Bootstrap Index using HFile and File System View Changes with unit-test
URL: https://github.com/apache/incubator-hudi/pull/1459#discussion_r404455728
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -328,7 +377,8 @@ protected FileSlice
filterBaseFileAfterPendingCompaction(FileSlice fileSlice) {
readLock.lock();
String partitionPath = formatPartitionKey(partitionStr);
ensurePartitionLoadedCorrectly(partitionPath);
- return fetchLatestBaseFiles(partitionPath);
+ return fetchLatestBaseFiles(partitionPath)
+ .map(df -> addExternalBaseFileIfPresent(new
HoodieFileGroupId(partitionPath, df.getFileId()), df));
Review comment:
Do we need to add external file again, given `fetchLatestBaseFiles` already
adds the external file ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
