alexeykudinkin commented on code in PR #6170:
URL: https://github.com/apache/hudi/pull/6170#discussion_r942631573
##########
hudi-spark-datasource/hudi-spark/pom.xml:
##########
@@ -267,6 +252,14 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</dependency>
+ <dependency>
Review Comment:
As discussed on Slack: all terminal modules have to have it as compile deps
(cli, integ-tests, etc), the library ones have to be provided
(hudi-spark-bundle, hudi-flink-bundle, etc).
Using tests is a good signal but we need to keep in mind that it's not gonna
be covering everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
