[GitHub] [hudi] YannByron commented on a diff in pull request #6476: [HUDI-3478] Support CDC for Spark in Hudi

Tue, 30 Aug 2022 01:07:11 -0700 


YannByron commented on code in PR #6476:
URL: https://github.com/apache/hudi/pull/6476#discussion_r958150314


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -229,6 +230,10 @@ protected synchronized void scanInternal(Option<KeySpec> 
keySpecOpt) {
         HoodieLogBlock logBlock = logFormatReaderWrapper.next();
         final String instantTime = 
logBlock.getLogBlockHeader().get(INSTANT_TIME);
         totalLogBlocks.incrementAndGet();
+        if (logBlock.getBlockType() == CDC_DATA_BLOCK) {
+          // hit a cdc block, just skip.
+          continue;

Review Comment:
   according to the following logic, even the block doesn't be read, 
`totalLogBlocks` also should increment.
   
![image](https://user-images.githubusercontent.com/10036681/187384289-bf2323b8-2b22-45b9-8c49-13c5eba9145e.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to