YannByron commented on code in PR #6476: URL: https://github.com/apache/hudi/pull/6476#discussion_r958152013
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/CDCLogRecordReader.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.log; + +import org.apache.avro.generic.IndexedRecord; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +import org.apache.hudi.common.model.HoodieLogFile; +import org.apache.hudi.common.table.cdc.CDCUtils; +import org.apache.hudi.common.table.log.block.HoodieDataBlock; +import org.apache.hudi.common.table.log.block.HoodieLogBlock; +import org.apache.hudi.common.util.ClosableIterator; + +import java.io.IOException; + +public class CDCLogRecordReader implements ClosableIterator<IndexedRecord> { + + private final HoodieLogFile cdcLogFile; + + private final HoodieLogFormat.Reader reader; + + private ClosableIterator<IndexedRecord> itr; + + public CDCLogRecordReader(FileSystem fs, Path cdcLogPath, String cdcSupplementalLoggingMode) throws IOException { + this.cdcLogFile = new HoodieLogFile(fs.getFileStatus(cdcLogPath)); + this.reader = new HoodieLogFileReader(fs, cdcLogFile, + CDCUtils.schemaBySupplementalLoggingMode(cdcSupplementalLoggingMode), + HoodieLogFileReader.DEFAULT_BUFFER_SIZE, false); + } + + @Override + public boolean hasNext() { + if (null == itr || !itr.hasNext()) { + if (reader.hasNext()) { + HoodieDataBlock dataBlock = (HoodieDataBlock) reader.next(); + if (dataBlock.getBlockType() == HoodieLogBlock.HoodieLogBlockType.CDC_DATA_BLOCK) { + itr = dataBlock.getRecordIterator(); + return itr.hasNext(); + } else { + return hasNext(); + } + } + return false; + } + return true; + } + + @Override + public IndexedRecord next() { + return itr.next(); + } + + @Override + public void close() { + try { + itr.close(); + reader.close(); + } catch (IOException e) { + e.printStackTrace(); Review Comment: ok. but i need catch IOException first and convert it to `HoodeIOException` because `reader.close` will throw IOException which is not `RuntimeException`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
