nsivabalan commented on code in PR #5958:
URL: https://github.com/apache/hudi/pull/5958#discussion_r958602423
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -456,6 +491,23 @@ public List<WriteStatus> close() {
}
}
+ public void write(Map<String, HoodieRecord<? extends HoodieRecordPayload>>
recordMap) {
+ Iterator<String> keyIterator = recordMap.keySet().stream().iterator();
+ try {
+ while (keyIterator.hasNext()) {
+ final String key = keyIterator.next();
+ HoodieRecord<T> record = (HoodieRecord<T>) recordMap.get(key);
+ init(record);
+ // For logCompaction operations all the records are read and written
as a huge block.
Review Comment:
@prasannarajaperumal : something to note. we are not doing a streaming
write. we are essentially reading all records and then passing the hashmap of
records to Appendhandle to write it out. wanted to bring it up to your notice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
