danny0405 commented on code in PR #4676:
URL: https://github.com/apache/hudi/pull/4676#discussion_r967961241
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkWriteHelper.java:
##########
@@ -97,7 +98,9 @@ public List<HoodieRecord<T>> deduplicateRecords(
final T data1 = rec1.getData();
final T data2 = rec2.getData();
- @SuppressWarnings("unchecked") final T reducedData = (T)
data2.preCombine(data1);
+ Properties properties = new Properties();
+ properties.put("schema", schemaString);
+ @SuppressWarnings("unchecked") final T reducedData = (T)
data2.preCombine(data1, properties);
Review Comment:
Should we put the schema string into the properties ? `HoodiePayloadConfig`
does not include the schema string, how about we change the method signature
into `HoodieRecordPayload#preCombine(T oldValue, Schema schema, Properties
properties)`, just like what we do to
`HoodieRecordPayload#combineAndGetUpdateValue(IndexedRecord currentValue,
Schema schema, Properties properties)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
