danny0405 commented on code in PR #4676:
URL: https://github.com/apache/hudi/pull/4676#discussion_r970278114
##########
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteNonDefaultsWithLatestAvroPayload.java:
##########
@@ -58,6 +58,10 @@ public Option<IndexedRecord>
combineAndGetUpdateValue(IndexedRecord currentValue
GenericRecord insertRecord = (GenericRecord) recordOption.get();
GenericRecord currentRecord = (GenericRecord) currentValue;
+ return getMergedIndexedRecordOption(schema, insertRecord, currentRecord);
+ }
+
+ protected Option<IndexedRecord> getMergedIndexedRecordOption(Schema schema,
GenericRecord insertRecord, GenericRecord currentRecord) {
if (isDeleteRecord(insertRecord)) {
Review Comment:
Just name it `mergeRecords`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
