danny0405 commented on code in PR #4676:
URL: https://github.com/apache/hudi/pull/4676#discussion_r970631233
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseWriteHelper.java:
##########
@@ -81,10 +81,10 @@ public I combineOnCondition(
* @return Collection of HoodieRecord already be deduplicated
*/
public I deduplicateRecords(
- I records, HoodieTable<T, I, K, O> table, int parallelism) {
- return deduplicateRecords(records, table.getIndex(), parallelism);
+ I records, HoodieTable<T, I, K, O> table, int parallelism, String
schema) {
+ return deduplicateRecords(records, table.getIndex(), parallelism, schema);
}
public abstract I deduplicateRecords(
- I records, HoodieIndex<?, ?> index, int parallelism);
+ I records, HoodieIndex<?, ?> index, int parallelism, String
schemaString);
Review Comment:
schemaString -> schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
