[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1469: [HUDI-686] Implement BloomIndexV2 that does not depend on memory caching

Wed, 22 Apr 2020 05:42:25 -0700 


lamber-ken commented on a change in pull request #1469:
URL: https://github.com/apache/incubator-hudi/pull/1469#discussion_r412946904



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieTimer.java
##########
@@ -69,4 +76,13 @@ public long endTimer() {
     }
     return timeInfoDeque.pop().stop();
   }
+
+  public long deltaTime() {

Review comment:
       `endTimer` can only support 1 v 1, what we need here is `delta` 
characteristics.
   if use `endTimer`, we must create many instances, only one instance is 
enough when we use `delta`. 
   
   
![image](https://user-images.githubusercontent.com/20113411/79982927-9ae9ba80-84d9-11ea-84af-1a6e7565a482.png)
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to