vinothchandar commented on a change in pull request #1469:
URL: https://github.com/apache/incubator-hudi/pull/1469#discussion_r413300954
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieTimer.java
##########
@@ -69,4 +76,13 @@ public long endTimer() {
}
return timeInfoDeque.pop().stop();
}
+
+ public long deltaTime() {
Review comment:
let's just reuse the timer class as is and move on? :) I'd actually
encourage explicit start and end calls so its clear what is being measured? In
any case, the current way of overloading `HoodieTimer` does not seem
maintainable IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]