xicm commented on PR #6899:
URL: https://github.com/apache/hudi/pull/6899#issuecomment-1272781782

   > The intention is to always infer `META_SYNC_PARTITION_FIELDS` and 
`META_SYNC_PARTITION_EXTRACTOR_CLASS` from table config or keygen options. So 
we should keep the inference consistent. If you manually overwrite 
`META_SYNC_PARTITION_FIELDS`, you want to overwrite 
`META_SYNC_PARTITION_EXTRACTOR_CLASS` as well.
   
   Hi @xushiyan , I want this inference to also work with 
META_SYNC_PARTITION_FIELDS, is it necessary?
   
   And another question, If HoodieTableConfig.PARTITION_FIELDS or 
KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME is null, 
META_SYNC_PARTITION_EXTRACTOR_CLASS will be default value 
MultiPartKeysValueExtractor. In general, partition field is null, the table may 
be a non-parition table, is the default extractor class reasonablle?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to