xicm commented on code in PR #6899:
URL: https://github.com/apache/hudi/pull/6899#discussion_r991045336
##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncConfig.java:
##########
@@ -94,28 +94,22 @@ public class HoodieSyncConfig extends HoodieConfig {
public static final ConfigProperty<String>
META_SYNC_PARTITION_EXTRACTOR_CLASS = ConfigProperty
.key("hoodie.datasource.hive_sync.partition_extractor_class")
- .defaultValue("org.apache.hudi.hive.MultiPartKeysValueExtractor")
+ .defaultValue("org.apache.hudi.hive.NonPartitionedExtractor")
.withInferFunction(cfg -> {
- Option<String> partitionFieldsOpt =
Option.ofNullable(cfg.getString(HoodieTableConfig.PARTITION_FIELDS))
- .or(() ->
Option.ofNullable(cfg.getString(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME)));
- if (!partitionFieldsOpt.isPresent()) {
+ Option<String> partitionFieldsOpt =
Option.ofNullable(cfg.getString(META_SYNC_PARTITION_FIELDS));
Review Comment:
META_SYNC_PARTITION_FIELDS is inferred from
HoodieTableConfig.PARTITION_FIELDS and
KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME, so I think it is ok to infrer
META_SYNC_PARTITION_EXTRACTOR_CLASS from META_SYNC_PARTITION_FIELDS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
