voonhous commented on code in PR #6915:
URL: https://github.com/apache/hudi/pull/6915#discussion_r991886189
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -142,7 +143,7 @@ private void sanityCheck(Configuration conf, ResolvedSchema
schema) {
// validate pre_combine key
String preCombineField = conf.get(FlinkOptions.PRECOMBINE_FIELD);
- if (!fields.contains(preCombineField)) {
+ if (!fields.contains(getRootLevelFieldName(preCombineField))) {
if (OptionsResolver.isDefaultHoodieRecordPayloadClazz(conf)) {
Review Comment:
I agree. This change is to standardize the validations between Flink and
Spark. As such, no checks on the nested field names were made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
