voonhous commented on code in PR #6915:
URL: https://github.com/apache/hudi/pull/6915#discussion_r991886945
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java:
##########
@@ -165,6 +165,35 @@ void testRequiredOptionsForSource() {
assertDoesNotThrow(() -> new
HoodieTableFactory().createDynamicTableSource(sourceContext6));
assertDoesNotThrow(() -> new
HoodieTableFactory().createDynamicTableSink(sourceContext6));
+
+ // nested pk field is allowed
+ ResolvedSchema schema6 = SchemaBuilder.instance()
+ .field("f0",
+ DataTypes.ROW(DataTypes.FIELD("id", DataTypes.INT()),
DataTypes.FIELD("date", DataTypes.VARCHAR(20))))
Review Comment:
Hmmm, do you mean add IT tests?
Or remove the UT i included here and rewrite them as IT tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
