danny0405 commented on code in PR #5991:
URL: https://github.com/apache/hudi/pull/5991#discussion_r1004082925
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java:
##########
@@ -74,14 +74,14 @@ public class CompactFunction extends
ProcessFunction<CompactionPlanEvent, Compac
public CompactFunction(Configuration conf) {
this.conf = conf;
- this.asyncCompaction = OptionsResolver.needsAsyncCompaction(conf);
+ this.asyncCompactionOperation =
OptionsResolver.needsAsyncCompactionOperation(conf);
}
Review Comment:
> And actually the bounded source sync compaction seems weird. It use
compaction.async.enabled true to turn on compaction, and then switch it to
fasle for sync mode.
I agree the logic here is a little weird, we can refactor it though,
the bounded source sync compaction is meaningful, especially when people do
batch ingestion for mor table, they do not what a separate compaction job
running again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
