danny0405 commented on code in PR #5991:
URL: https://github.com/apache/hudi/pull/5991#discussion_r1004111744
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java:
##########
@@ -74,14 +74,14 @@ public class CompactFunction extends
ProcessFunction<CompactionPlanEvent, Compac
public CompactFunction(Configuration conf) {
this.conf = conf;
- this.asyncCompaction = OptionsResolver.needsAsyncCompaction(conf);
+ this.asyncCompactionOperation =
OptionsResolver.needsAsyncCompactionOperation(conf);
}
Review Comment:
> But we met cases that async compaction with watermark will cause
compaction msgs missed. Thus we will keep sync compaction as an option for
unbounded source.
Can you elaborate more for the details here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
