alexeykudinkin commented on code in PR #6227:
URL: https://github.com/apache/hudi/pull/6227#discussion_r1006125869
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -639,7 +639,6 @@
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
- <classifier>nohive</classifier>
Review Comment:
@xushiyan let me take back my 2d point:
We should actually not be depending on this modules directly -- for reading
these file-formats we're relying on readers provided by the execution engine(s)
and therefore should not depend on these modules directly for that.
The only other use-case i see us depending on these modules for are schema
conversions in hive-sync, hadoop-mr bundles. For that we can (and should) shade
these deps indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
