alexeykudinkin commented on code in PR #6227:
URL: https://github.com/apache/hudi/pull/6227#discussion_r1006233623
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -639,7 +639,6 @@
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
- <classifier>nohive</classifier>
Review Comment:
> When you say "interfacing w/ the execution engine" it's meant for class
loading, which should be addressed at code level, like avoid calling APIs that
load hardcoded classes, which i think it's rare situations (Kryo is one of
those)
It's not only that, it's that you might be creating an object of class X and
passing it to the execution engine -- in that case both have to share the class
X (therefore you can't shade it in one of them).
Please check my other comment though, i don't think this is the case for us,
and so we should be able to shade actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
