danny0405 commented on code in PR #7097:
URL: https://github.com/apache/hudi/pull/7097#discussion_r1010222957
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -347,4 +351,12 @@ private static void inferAvroSchema(Configuration conf,
LogicalType rowType) {
conf.setString(FlinkOptions.SOURCE_AVRO_SCHEMA, inferredSchema);
}
}
+
+ private static void setupRootOptions(Configuration conf, ReadableConfig
configuration) {
+ if (configuration instanceof TableConfig) {
+ ((Configuration)((TableConfig)
configuration).getRootConfiguration()).toMap().forEach((rootConfigKey,
rootConfigValue) -> {
+ conf.setString(rootConfigKey, rootConfigValue);
Review Comment:
The `TableConfig` is used for passing around Flink SQL job config options,
not very suitable for hadoop configurations.
Can you just put the specific hadoop config options into the hadoop
`core-site.xml` file which stays under the dir `HADOOP_CONF_DIR`
`HADOOP_HOME/conf` `HADOOP_HOME/etc/hadoop` ?
Or just use the table options which are supported now ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
