boneanxs commented on code in PR #7067:
URL: https://github.com/apache/hudi/pull/7067#discussion_r1011666628
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -459,7 +467,10 @@ private Stream<HoodieInstant> getCommitInstantsToArchive()
{
oldestInstantToRetainForCompaction.map(instantToRetain ->
compareTimestamps(s.getTimestamp(), LESSER_THAN,
instantToRetain.getTimestamp()))
.orElse(true)
- );
+ ).filter(s ->
Review Comment:
we need to make sure archival does not make progress further than latest
clean, so here we compare the instants to not great than the
latestCompleteCleanInstant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
