nsivabalan commented on code in PR #7067:
URL: https://github.com/apache/hudi/pull/7067#discussion_r1012400137
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -459,7 +467,10 @@ private Stream<HoodieInstant> getCommitInstantsToArchive()
{
oldestInstantToRetainForCompaction.map(instantToRetain ->
compareTimestamps(s.getTimestamp(), LESSER_THAN,
instantToRetain.getTimestamp()))
.orElse(true)
- );
+ ).filter(s ->
Review Comment:
not sure if this is valid for all policies. for eg, wrt Cleaning based on
FILE_VERSIONS, I don't think we have any relation b/w archival and cleaning.
wrt Cleaning based on COMMITS, may be its true.
So, probably we can't add this enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
