boneanxs commented on code in PR #6921:
URL: https://github.com/apache/hudi/pull/6921#discussion_r1020707598
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSourceStorage.scala:
##########
@@ -167,12 +167,15 @@ class TestCOWDataSourceStorage extends
SparkClientFunctionalTestHarness {
// Read Incremental Query
// we have 2 commits, try pulling the first commit (which is not the
latest)
val firstCommit = HoodieDataSourceHelpers.listCommitsSince(fs, basePath,
"000").get(0)
+ // Setting HoodieROTablePathFilter here to test whether pathFilter can
filter out correctly for IncrementalRelation
+
spark.sparkContext.hadoopConfiguration.set("mapreduce.input.pathFilter.class",
"org.apache.hudi.hadoop.HoodieROTablePathFilter")
Review Comment:
I think the intend of the test is to test if `HoodieROTablePathFilter` is
set, the incremental relation still can read the old data correctly. But this
test doesn't work as our expect, as `HoodieROTablePathFilter` is not set by
default.
can see if we run this test without setting pathFilter explicitly.
<img width="1508" alt="Screen Shot 2022-11-12 at 14 59 41"
src="https://user-images.githubusercontent.com/10115332/201461922-b546e09d-eeaa-44c0-acdb-01f89ac830ec.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/10115332/201461922-b546e09d-eeaa-44c0-acdb-01f89ac830ec.png"](https://user-images.githubusercontent.com/10115332/201461922-b546e09d-eeaa-44c0-acdb-01f89ac830ec.png"){kind=link}