boneanxs commented on code in PR #6921:
URL: https://github.com/apache/hudi/pull/6921#discussion_r1023483789
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSourceStorage.scala:
##########
@@ -167,12 +167,15 @@ class TestCOWDataSourceStorage extends
SparkClientFunctionalTestHarness {
// Read Incremental Query
// we have 2 commits, try pulling the first commit (which is not the
latest)
val firstCommit = HoodieDataSourceHelpers.listCommitsSince(fs, basePath,
"000").get(0)
+ // Setting HoodieROTablePathFilter here to test whether pathFilter can
filter out correctly for IncrementalRelation
+
spark.sparkContext.hadoopConfiguration.set("mapreduce.input.pathFilter.class",
"org.apache.hudi.hadoop.HoodieROTablePathFilter")
Review Comment:
Yea, there is a test in
`org.apache.hudi.functional.TestCOWDataSource#testReadPathsOnCopyOnWriteTable`
https://github.com/apache/hudi/blob/7e7b3a866b549021c5a7ad9f89f0da90aff7da68/hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala#L341
actually test this. `toHadoopRelation` will add the `HoodieROTablePathFilter`,
and this test also contains old version files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
