xushiyan commented on code in PR #7167:
URL: https://github.com/apache/hudi/pull/7167#discussion_r1020842055
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java:
##########
@@ -116,7 +121,15 @@ default Option<IndexedRecord>
combineAndGetUpdateValue(IndexedRecord currentValu
*/
@PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
default Option<IndexedRecord> getInsertValue(Schema schema, Properties
properties) throws IOException {
- return getInsertValue(schema);
+ boolean dropPartCol =
Boolean.parseBoolean(properties.getProperty(HoodieTableConfig.DROP_PARTITION_COLUMNS.key()));
Review Comment:
this won't be effective on some default payload classes like
`DefaultHoodieRecordPayload`. can we audit the subclasses and fix altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
