[GitHub] [hudi] eric9204 commented on a diff in pull request #7167: [HUDI-5094] Remove partition fields before transform bytes to avro,if enable DROP_PARTITION_COLUMNS.

Sun, 13 Nov 2022 23:07:57 -0800 


eric9204 commented on code in PR #7167:
URL: https://github.com/apache/hudi/pull/7167#discussion_r1021136971


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java:
##########
@@ -116,7 +121,15 @@ default Option<IndexedRecord> 
combineAndGetUpdateValue(IndexedRecord currentValu
    */
   @PublicAPIMethod(maturity = ApiMaturityLevel.STABLE)
   default Option<IndexedRecord> getInsertValue(Schema schema, Properties 
properties) throws IOException {
-    return getInsertValue(schema);
+    boolean dropPartCol = 
Boolean.parseBoolean(properties.getProperty(HoodieTableConfig.DROP_PARTITION_COLUMNS.key()));

Review Comment:
   have fix all subclasses which extends `HoodieRecordPayload` and overwrite 
`getInsertValue(Schema schema, Properties properties) `，Except 
`ExpressionPayload.java`, this payload is used for spark sql, and it works fine 
with `hoodie.datasource.write.drop.partition.columns =true, ` 
   in my opinion, there's no need to change it. what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to