xiarixiaoyao commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r1022510833
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatReader.java:
##########
@@ -52,9 +53,9 @@ public class HoodieLogFormatReader implements
HoodieLogFormat.Reader {
private static final Logger LOG =
LogManager.getLogger(HoodieLogFormatReader.class);
- HoodieLogFormatReader(FileSystem fs, List<HoodieLogFile> logFiles, Schema
readerSchema, boolean readBlocksLazily,
Review Comment:
we can remove internalSchema directly.
internralSchema is only used to indicate current hudi table has done schema
evolution. and we should use writeSchema to read logblock.
if schemaEvolution is disabled, let's pass readerSchema as null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
