xiarixiaoyao commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r1022523171
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataMergedLogRecordReader.java:
##########
@@ -54,15 +54,15 @@ public class HoodieMetadataMergedLogRecordReader extends
HoodieMergedLogRecordSc
private HoodieMetadataMergedLogRecordReader(FileSystem fs, String basePath,
String partitionName,
List<String> logFilePaths,
- Schema readerSchema, String
latestInstantTime,
+ InternalSchema readerSchema,
String latestInstantTime,
Long maxMemorySizeInBytes, int
bufferSize,
String spillableMapBasePath,
ExternalSpillableMap.DiskMapType
diskMapType,
boolean
isBitCaskDiskMapCompressionEnabled,
Option<InstantRange>
instantRange, boolean allowFullScan, boolean useScanV2) {
super(fs, basePath, logFilePaths, readerSchema, latestInstantTime,
maxMemorySizeInBytes, true, false, bufferSize,
spillableMapBasePath, instantRange, diskMapType,
isBitCaskDiskMapCompressionEnabled, false, allowFullScan,
- Option.of(partitionName), InternalSchema.getEmptyInternalSchema(),
useScanV2);
+ Option.of(partitionName), useScanV2);
Review Comment:
No need to modify this class
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -491,7 +492,7 @@ public Pair<HoodieMetadataMergedLogRecordReader, Long>
getLogRecordScanner(List<
.withFileSystem(metadataMetaClient.getFs())
.withBasePath(metadataBasePath)
.withLogFilePaths(sortedLogFilePaths)
- .withReaderSchema(schema)
+ .withReaderSchema(AvroInternalSchemaConverter.convertToEmpty(schema))
Review Comment:
HoodieBackedTableMetadata no support scheam evolution.
No need to modify this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
