YannByron commented on code in PR #7196:
URL: https://github.com/apache/hudi/pull/7196#discussion_r1032443092
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -267,21 +267,27 @@ public void deleteCompactionRequested(HoodieInstant
instant) {
}
public void deleteInstantFileIfExists(HoodieInstant instant) {
+ deleteInstantFileIfExists(instant, true);
+ }
+
+ public boolean deleteInstantFileIfExists(HoodieInstant instant, boolean
exceptionIfFailToDelete) {
LOG.info("Deleting instant " + instant);
- Path inFlightCommitFilePath =
getInstantFileNamePath(instant.getFileName());
+ Path commitFilePath = getInstantFileNamePath(instant.getFileName());
Review Comment:
then we should add some doc for this method. `inFlightCommitFilePath`
doesn't represent requested and empty clean instant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
