YannByron commented on PR #7196: URL: https://github.com/apache/hudi/pull/7196#issuecomment-1327471558
> * at timeline API level, we should not allow ignoring error; this affects data integrity i thought there was a case that need to ignore this error. Will correct this. > * there is another API `org.apache.hudi.common.table.timeline.HoodieActiveTimeline#deleteInstantFile(org.apache.hudi.common.table.timeline.HoodieInstant)` to be consolidated/dedup'ed I know that and have did this. But Danny suggests that make this pr force on one question. > * pls file jira as this touches critical code path, also properly fill the PR template "Impact" and "Risk" sections OK. > * pls help increase UT coverage for critical APIs wherever applicable the existing UT is enough to cover this improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
