xushiyan commented on code in PR #7305:
URL: https://github.com/apache/hudi/pull/7305#discussion_r1032806413
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestUpdateSchemaEvolution.java:
##########
@@ -59,7 +60,7 @@
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertThrows;
-public class TestUpdateSchemaEvolution extends HoodieClientTestHarness {
+public class TestUpdateSchemaEvolution extends HoodieClientTestHarness
implements Serializable {
Review Comment:
only make subclass serializable as needed
##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -316,43 +320,17 @@ public void testMultipleAppend(HoodieLogBlockType
dataBlockType) throws IOExcept
}, "getCurrentSize should fail after the logAppender is closed");
}
- /*
- * This is actually a test on concurrent append and not recovery lease.
Commenting this out.
- * https://issues.apache.org/jira/browse/HUDI-117
- */
-
- /**
- * @Test public void testLeaseRecovery() throws IOException,
URISyntaxException, InterruptedException { Writer writer
Review Comment:
as the comment mentions, this testcase is not as the name suggests, also the
logic is covered in other test case, hence removing it
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieReadClient.java:
##########
@@ -50,16 +48,7 @@
@SuppressWarnings("unchecked")
public class TestHoodieReadClient extends HoodieClientTestBase {
- @Override
- protected void initPath() {
Review Comment:
prefer to use the one in super class so remove this method in subclass
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/minicluster/MiniClusterUtil.java:
##########
@@ -1,59 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.hudi.common.testutils.minicluster;
-
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.hdfs.MiniDFSCluster;
-import org.apache.zookeeper.server.ZooKeeperServer;
-
-import java.io.IOException;
-
-/**
- * A utility class about mini cluster.
- */
-public class MiniClusterUtil {
Review Comment:
discard this as it bundles hdfs with zookeeper, which should be discouraged
for UT/FT. testcase which needs hdfs will use `HdfsTestService` where applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
