nsivabalan commented on code in PR #7305:
URL: https://github.com/apache/hudi/pull/7305#discussion_r1033030337
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestMultiFS.java:
##########
@@ -102,28 +127,28 @@ public void readLocalWriteHDFS() throws Exception {
// Write generated data to hdfs (only inserts)
String readCommitTime = hdfsWriteClient.startCommit();
LOG.info("Starting commit " + readCommitTime);
- List<HoodieRecord> records = dataGen.generateInserts(readCommitTime,
100);
- JavaRDD<HoodieRecord> writeRecords = jsc.parallelize(records, 1);
+ List<HoodieRecord> records = dataGen.generateInserts(readCommitTime, 10);
Review Comment:
some of the test assumes that records will span across all 3 partition paths
(HoodieTestDataGenerator). if we reduce the num of records from 100 to 10,
chances we might see some flakiness. something to keep in mind.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestMergeOnReadRollbackActionExecutor.java:
##########
@@ -89,7 +88,7 @@ public void tearDown() throws Exception {
}
@ParameterizedTest
- @ValueSource(booleans = {true})
+ @ValueSource(booleans = {false, true})
Review Comment:
do we know why this was not having "false" before. may be we had some reason
to remove it explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
