yanghua commented on a change in pull request #1572:
URL: https://github.com/apache/incubator-hudi/pull/1572#discussion_r421982141
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieMetricsConfig.java
##########
@@ -92,28 +103,63 @@ public Builder withReporterType(String reporterType) {
return this;
}
- public Builder toGraphiteHost(String host) {
+ public Builder withGraphiteHost(String host) {
Review comment:
I have two opinions about these changes:
- Does it break the compatibility?
- Packaging different config options of different reporters in one class is
not a good choice, it would be better to refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
