xushiyan commented on a change in pull request #1572:
URL: https://github.com/apache/incubator-hudi/pull/1572#discussion_r422526655
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieMetricsConfig.java
##########
@@ -92,28 +103,63 @@ public Builder withReporterType(String reporterType) {
return this;
}
- public Builder toGraphiteHost(String host) {
+ public Builder withGraphiteHost(String host) {
Review comment:
These builder methods are not used by any logic. I think they are legacy
code and only mentioned in config docs. I'm changing the names in #1603 too.
You're right that we should segregate the configs for different reporter
types. It shouldn't give too much hassle to do refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
